Don’t override flake ref if no url or type provided#7176
Closed
matthewbauer wants to merge 1 commit intoNixOS:masterfrom
Closed
Don’t override flake ref if no url or type provided#7176matthewbauer wants to merge 1 commit intoNixOS:masterfrom
matthewbauer wants to merge 1 commit intoNixOS:masterfrom
Conversation
We have a situation where we want to override an input’s input, but
not the input itself. It looks something like:
inputs.a = {
type = "github";
owner = "example";
repo = "a";
inputs.b.inputs.nixpkgs.follows = "nixpkgs";
};
The problem is that Nix thinks we are overriding "b", when we are
really only wanting to override one of "b"’s inputs. The flake url
should remain the same, but with existing behavior, Nix assign "b" to
be an indirect input, and ignores the "b" from "a"s inputs. We want it
to behave more like the "follows" and not treat it as a full override
of "b".
Contributor
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a situation where we want to override an input’s input, but not the input itself. It looks something like:
The problem is that Nix thinks we are overriding "b", when we are really only wanting to override one of "b"’s inputs. The flake url should remain the same, but in the past behavior, Nix assigns "b" to an indirect input, and ignores the "b" from "a"s inputs. We want it to behave more like the "follows" and not treat it as a full override of "b".