systemd,launchd match nixos open files limit

[Artturin]

it was bumped in NixOS/nixpkgs#176558

[edolstra]

1 million file descriptors sounds rather excessive. If Nix really needs that many, it's clearly a bug.

[Artturin]

I just chose some random value i found in a stackoverflow post and didn't see a reason to make it lower

[roberth]

1 million file descriptors sounds rather excessive. If Nix really needs that many, it's clearly a bug.

Nix only needs like 3.
The question is what does a user's derivation need? A million is only excessive until it is not, but probably not enough to cause issues on the system.

clearly a bug

Or a highly concurrent test suite that's heavy on fds.

[lovesegfault]

@edolstra Can you take another look at this?

I can't build many derivations on macOS without manually patching the plist like this; otherwise it complains about too many open files.

[mstone]

I also recently ran into (another) derivation that needed a higher limit than was provided by default [ IIRC, testing out a mass-rebuild-causing change that had been merged into staging ] and so would appreciate a fix along these lines ~regardless of what number is ultimately chosen.

[github-actions]

Successfully created backport PR #7432 for 2.11-maintenance.

[Artturin]

Thanks thufschmitt & edolstra

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2022-12-09-nix-team-meeting-minutes-15/23951/1

[github-actions]

Backport failed for 2.11-maintenance, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin 2.11-maintenance
git worktree add -d .worktree/backport-6645-to-2.11-maintenance origin/2.11-maintenance
cd .worktree/backport-6645-to-2.11-maintenance
git checkout -b backport-6645-to-2.11-maintenance
ancref=$(git merge-base 499e99d099ec513478a2d3120b2af3a16d9ae49d 2320a2f93e0aa61e8d45dcfb3fb536361a1fcb6f)
git cherry-pick -x $ancref..2320a2f93e0aa61e8d45dcfb3fb536361a1fcb6f

[github-actions]

Successfully created backport PR #7618 for 2.12-maintenance.