nix: Add forgotten null check in AttrCursor::getListOfStrings()#6489
Merged
edolstra merged 2 commits intoNixOS:masterfrom May 5, 2022
Merged
nix: Add forgotten null check in AttrCursor::getListOfStrings()#6489edolstra merged 2 commits intoNixOS:masterfrom
edolstra merged 2 commits intoNixOS:masterfrom
Conversation
Regression test for <NixOS#6488>
thufschmitt
approved these changes
May 5, 2022
Member
thufschmitt
left a comment
thufschmitt
left a comment
There was a problem hiding this comment.
Thanks :)
I’ve pushed a quick test (far from ideal, but I’m not sure how we can reliably test something like that without putting in a significant effort which is out of scope here), looks good otherwise 👍
I’ll just wait for the CI to finish and merge (don’t hesitate to ping me if I forget)
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6488.
This is in no way perfect (a test would be nice, for one thing), but to my (inexperienced) eyes it seems to point out the problem, so feel free to either tell me how you’d like this packaged or just take and rewrite it.