tests: Fix the start of the daemon#6179
Conversation
- Make sure that it starts even without the `nix-command` xp feature - Fail if it doesn’t manage to start This fixes a 30s wait for every test in `init.sh` as the daemon couldn’t start, but the code was just waiting 30s and continuing as if everything was all right.
Which in practice means that the CA is faster by something between 20 and 40 mins :) |
|
@thufschmitt this overlaps a bit with my #5753, I guess I will rebase that but I hope we can do both. |
Ah, I knew you had something touching the same bits of code :) (and looks like yours would fix the issue too). If you’re OK rebasing, I’ll merge that one right now as the CI times are really a pain and that’s the quickest fix |
|
@thufschmitt Yes I am totally fine rebasing. Sound good! |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/tweag-nix-dev-update-25/18003/1 |
3 participants
nix-commandxp featureThis fixes a 30s wait for every test in
init.shas the daemon couldn’t start, but the code was just waiting 30s and continuing as if everything was all right.