[backport 2.4] Recent merged testsuite improvements#5755
Merged
edolstra merged 2 commits intoNixOS:2.4-maintenancefrom Dec 15, 2021
Merged
[backport 2.4] Recent merged testsuite improvements#5755edolstra merged 2 commits intoNixOS:2.4-maintenancefrom
edolstra merged 2 commits intoNixOS:2.4-maintenancefrom
Conversation
Having the `post-build-hook` use `nix` from the client package can lead to a deadlock in case there’s a db migration to do between both, as a `nix` command running inside the hook will run as root (and as such will bypass the daemon), so might trigger a db migration, which will get stuck trying to get a global lock on the DB (as the daemon that ran the hook already has a lock on it). (cherry picked from commit 93eadd5)
The eventual PATH entry needs the `.../bin` or we will not use the right daemon. (cherry picked from commit 06fb6ae)
Member
|
IMHO backport PRs should be made after the master PR has been merged (via |
Member
Author
|
Yeah sorry, I got eager and thought those were about to pass, and wanted to make sure the cross-version testing works. |
Ericson2314
force-pushed
the
2.4-improve-tests
branch
from
3914eca to
9c15e15
Compare
Member
Author
|
@edolstra this is now limited to the first two commits which were already merged. |
Ericson2314
changed the title
Ericson2314
changed the title
Member
Author
|
@edolstra ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.