[backport 2.3] Parallelize test suite#5649
Merged
edolstra merged 5 commits intoNixOS:2.3-maintenancefrom Dec 9, 2021
Merged
Conversation
Ericson2314
changed the title
5 tasks
Cause the time needed to run the testsuite to drop from ~4mins to ~40s (cherry picked from commit 1b5aa60)
Reuse the pre-existing list rather than the one written as part of NixOS#3777 (cherry picked from commit 5101ed1)
Fix a socket length failure on the OSX builders (cherry picked from commit 223fbe6)
For some reason, the bash shell started by 'nix develop' sometimes reads from stdin, which can hang. (cherry picked from commit 50a8710)
Without this, moving the nix-shell tests into a `nix-shell` dir breaks them. (cherry picked from commit a70706b)
Ericson2314
force-pushed
the
2.3-modernize-test-suite
branch
from
2e398e8 to
75bd197
Compare
|
🎉 All dependencies have been resolved ! |
thufschmitt
approved these changes
Dec 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first step to backporting the nix-2.4 test suite feature. The goal is to be able to make sure Nix 2.3 works with the Nix 2.4 daemon.
Unfortunately there is a weird error in the nix-shell test. It seems merely changing the location of theThe last cherry-picked fixes it.shell.shebang.shfile messed up the-I nixpkgs=shell.nix. I have no idea what this is about, except that it doesn't occur in Nix 2.4. The error message in https://discourse.nixos.org/t/weird-inconsistency-for-nix-shell-run/11730/5 seem possibly related.depends on #5688