Skip to content

Test against stable versions#5572

Closed
Ericson2314 wants to merge 1 commit into
NixOS:masterfrom
obsidiansystems:test-against-stable
Closed

Test against stable versions#5572
Ericson2314 wants to merge 1 commit into
NixOS:masterfrom
obsidiansystems:test-against-stable

Conversation

@Ericson2314
Copy link
Copy Markdown
Member

@Ericson2314 Ericson2314 commented Nov 16, 2021 •
edited
Loading

This will currently fail, but after #5571 and a bump to the 2.3 input, might succeed.

Helps with #12461

@thufschmitt
Copy link
Copy Markdown
Member

thufschmitt commented Nov 17, 2021

I’m not sure that we want to test against both 2.3 and 2.4 in the Github CI.
That would be great of course, but these tests are also quite costly, and the CI is already pretty slow. So maybe just sticking to 2.4 (or the version in nixpkgs as we currently do) would be enough.

Hydra is another matter, ofc, and it would probably make sense to have all these checks there

@Ericson2314
Copy link
Copy Markdown
Member Author

Ericson2314 commented Nov 17, 2021

@regnat That makes sense and sounds good to me. Also, I hope to backport this to 2.4, after which one could argue master testing 2.4 is enough.

@Ericson2314 Ericson2314 marked this pull request as ready for review November 17, 2021 22:41
@Ericson2314 Ericson2314 force-pushed the test-against-stable branch 3 times, most recently from fcfaf68 to d432508 Compare November 22, 2021 21:56
@Ericson2314 Ericson2314 mentioned this pull request Nov 22, 2021
Merged
@Ericson2314 Ericson2314 force-pushed the test-against-stable branch 8 times, most recently from 410ad45 to ec82df8 Compare November 24, 2021 02:14
@Ericson2314 Ericson2314 mentioned this pull request Nov 24, 2021
Merged
@Ericson2314 Ericson2314 mentioned this pull request Dec 7, 2021
Closed
@Ericson2314 Ericson2314 force-pushed the test-against-stable branch 2 times, most recently from b405e5a to a514f21 Compare December 9, 2021 15:42
@Ericson2314 Ericson2314 marked this pull request as draft December 15, 2021 01:59
@stale
Copy link
Copy Markdown

stale Bot commented Jun 13, 2022

I marked this as stale due to inactivity. → More info

@stale stale Bot added the stale label Jun 13, 2022
@fricklerhandwerk fricklerhandwerk added the with-tests Issues related to testing. PRs with tests have some priority label Sep 9, 2022
@Ericson2314
Copy link
Copy Markdown
Member Author

Ericson2314 commented Dec 13, 2022

@andir another such testing across versions PR.

@stale stale Bot removed the stale label Dec 13, 2022
@Ericson2314
Test against stable versions
7828452 
Add 2.3 to the flake, and adapt the test to also work with 2.3. Tests
fail, which is expected.

Also clean up some things in the test suite more generally.
@nixos-discourse
Copy link
Copy Markdown

nixos-discourse commented Mar 3, 2023

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-03-03-nix-team-meeting-minutes-37/25998/1

@tomberek
Copy link
Copy Markdown
Contributor

tomberek commented May 18, 2026

stale: re-open and re-base as needed

@tomberek tomberek closed this May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edolstra edolstra Awaiting requested review from edolstra edolstra will be requested when the pull request is marked ready for review edolstra is a code owner

Assignees

No one assigned

Labels

with-tests Issues related to testing. PRs with tests have some priority

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Ericson2314 @thufschmitt @nixos-discourse @tomberek @fricklerhandwerk