Skip to content

Allow to compile after ./configure --enable-gc=no#4947

Merged
edolstra merged 1 commit intoNixOS:masterfrom
Pamplemousse:disable_gc
Jul 5, 2021
Merged

Allow to compile after ./configure --enable-gc=no#4947
edolstra merged 1 commit intoNixOS:masterfrom
Pamplemousse:disable_gc

Conversation

@Pamplemousse
Copy link
Member

@Pamplemousse Pamplemousse commented Jun 25, 2021 •
edited
Loading

As of now, configuring with --enable-gc=no, and trying to compile triggers a

  CXX    src/libexpr/eval.o
src/libexpr/eval.cc:67:42: error: use of undeclared identifier 'traceable_allocator'
    return std::allocate_shared<Value *>(traceable_allocator<Value *>(), v);

This PR seems to fix it, but I have very low confidence in my C++.

cc @regnat

Signed-off-by: Pamplemousse xav.maso@gmail.com

@thufschmitt thufschmitt requested a review from edolstra June 28, 2021 14:44
edolstra
edolstra reviewed Jun 30, 2021
View reviewed changes
@Pamplemousse
Allow to compile after ./configure --enable-gc=no
5be17a4 
Signed-off-by: Pamplemousse <xav.maso@gmail.com>
@nixos-discourse
Copy link

nixos-discourse commented Jul 2, 2021

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/tweag-fellowship-fuzzing-nix-1/13904/1

@edolstra edolstra merged commit 24bc935 into NixOS:master Jul 5, 2021
@Pamplemousse Pamplemousse deleted the disable_gc branch July 5, 2021 16:13
@Pamplemousse Pamplemousse mentioned this pull request Jul 7, 2021
Closed
Pamplemousse added a commit to Pamplemousse/nix that referenced this pull request Jul 9, 2021
@Pamplemousse
Compiling without Boehm works
1756680 
  * seems to have been fixed by NixOS#4947
  * change option name to match current `./configure` option
  * tested by succesfully running `meson compile nixexpr`

Signed-off-by: Pamplemousse <xav.maso@gmail.com>
@Pamplemousse Pamplemousse mentioned this pull request Jul 9, 2021
Merged
Pamplemousse added a commit to Pamplemousse/nix that referenced this pull request Jul 9, 2021
@Pamplemousse
Compiling without Boehm works
a1a943c 
  * seems to have been fixed by NixOS#4947
  * change option name to match current `./configure` option
  * tested by succesfully running `meson compile nixexpr`

Signed-off-by: Pamplemousse <xav.maso@gmail.com>
Pamplemousse added a commit to Pamplemousse/nix that referenced this pull request Aug 9, 2021
@Pamplemousse
Compiling without Boehm works
010067f 
  * seems to have been fixed by NixOS#4947
  * change option name to match current `./configure` option
  * tested by succesfully running `meson compile nixexpr`

Signed-off-by: Pamplemousse <xav.maso@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edolstra edolstra edolstra left review comments

+1 more reviewer

@thufschmitt thufschmitt thufschmitt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Pamplemousse @nixos-discourse @edolstra @thufschmitt