Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore an accidentally suppressed negation #4828

Merged
merged 1 commit into from
May 18, 2021
Merged

Conversation

thufschmitt
Copy link
Member

Accidentally removed in ca96f52. This caused nix run to systematically fail with

error: app program '/nix/store/…' is not in the Nix store

Accidentally removed in ca96f52. This
caused `nix run` to systematically fail with

```
error: app program '/nix/store/…' is not in the Nix store
```
@andir
Copy link
Member

andir commented May 18, 2021

Perhaps time to add a simple run invocation to the tests?

@thufschmitt
Copy link
Member Author

Perhaps time to add a simple run invocation to the tests?

As a matter of fact, there is one, and it caught this all right. The problem (at least on my side) is #3605 which tends to make me ignore unexpected CI failures as “oh nvm, that’s the flaky darwin test striking again” (which is pretty stupid I guess, but…)

@edolstra edolstra merged commit 57f321f into master May 18, 2021
@edolstra edolstra deleted the ca/fix-nix-run branch May 18, 2021 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants