Check for rosetta 2 support before installing x86_64-darwin Nix #4305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewbauer
force-pushed
the
rosetta2-check
branch
from
a6aa252 to
b0de7b2
Compare
gnu-config standardized on aarch64 for machine name so host_cpu part of $system will always be aarch64. That means system will be aarch64-darwin too. uname however could report either “aarch64” (if gnu coreutils) or “arm64” (if apple’s uname). We should support both for compatiblity here.
matthewbauer
changed the title
|
Apple put my m1 mbp in the Post today. Will test before installing. |
|
Yes, the com.apple.oahd.plist does not exists on a new mbp m1. I just did ls on that path, but either ways, LGTM |
|
Thanks, merged! |
|
I've opened a PR on my fork at abathur#1 to hopefully bait some discussion about whether or not the installer should install rosetta automatically (and how). |
|
@matthewbauer would be great if you open a PR against |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for "rosetta 2" on ARM64 macOS first. Otherwise, installation will fail with:
Bad CPU type in executable
when running nix-store during later installation. This should be a safe check, but will need someone without rosetta 2 to verify this works as expected first (I've now installed it after setting up my new system).