Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import from derivation: Better queries, better errors #31

Closed
wants to merge 12 commits into from

Conversation

shlevy
Copy link
Member

@shlevy shlevy commented Jun 23, 2012

This is a new attempt at getting queries to work well with imports from derivations, taking the approach I suggested in the comments on the other PR. Note that currently the case where 'name' or 'system' require importing from an unrealized derivation (A silly case IMO) is not handled, though that can be easily added.

@shlevy
Copy link
Member Author

shlevy commented Jun 23, 2012

cc @edolstra

@shlevy
Copy link
Member Author

shlevy commented Jun 26, 2012

Oh, "the other PR" is #22 for those who haven't been following this work.

@shlevy
Copy link
Member Author

shlevy commented Jul 2, 2012

@edolstra ping

@shlevy
Copy link
Member Author

shlevy commented Jul 18, 2012

Any chance of this making it into 1.1?

@shlevy
Copy link
Member Author

shlevy commented Aug 26, 2012

@edolstra ping :)

@shlevy
Copy link
Member Author

shlevy commented Aug 29, 2012

@edolstra I've rebased onto latest master. I'll be doing more work on top of this branch, so future pull requests may assume this was merged.

@shlevy
Copy link
Member Author

shlevy commented Aug 29, 2012

Rebased, and I'll keep that up if more changes are pushed to master.

@@ -6,6 +6,29 @@
namespace nix {


string DrvInfo::queryName(EvalState & state) const
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for queryName() and querySystem()?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So getDerivation() doesn't need to evaluate any of the derivations attributes, and to allow graceful handling of the case where name or system depend on an import from derivation in the future

@shlevy
Copy link
Member Author

shlevy commented Jul 2, 2013

Giving up on this getting merged

@shlevy shlevy closed this Jul 2, 2013
@copumpkin
Copy link
Member

@edolstra can we reopen this?

@copumpkin
Copy link
Member

@shlevy thanks for doing this! Could you describe what this is doing to make it easier for someone to pick up and revive it? For example, how would I test that it's behaving as expected?

tebowy pushed a commit to tebowy/nix that referenced this pull request Jul 11, 2024
We're not going to use it.

Fixes: NixOS#31
Change-Id: Ib17a2eb6cae1ecbbf9ad1062e576ba6107a3c13b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants