Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes required to get nix working properly on Fedora #25

Closed
wants to merge 6 commits into from

Conversation

michel-slm
Copy link
Contributor

These commits reorganize the spec file and update the Nix profile script to make Nix usable out-of-the-box.

Michel Alexandre Salim added 4 commits May 27, 2012 16:41
  older RPM versions
- move tests to dedicated %check section
- use standard build macros
- incorporate NixOS's configuration so that nix is usable by normal
  users
- install as a data file, not a program file
- Fix license field
- Split into subpackages
- Update build dependencies
- Configure users and groups for multi-user mode
- Fix installation location of Perl modules
@michel-slm
Copy link
Contributor Author

note: the following changes are still forthcoming:

  • service definition for Nix worker
  • splitting Emacs nix-mode into nix-mode itself and nix-mode-init, so that users don't have to load the entire nix-mode unless they are editing Nix expressions
  • version bump

@michel-slm
Copy link
Contributor Author

Service definition added.

[Service]
Type=simple
#PIDFile=/var/run/tuned/tuned.pid
#BusName=com.redhat.tuned
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two lines should be removed.

Also, nix-worker.service should be added to EXTRA_DIST in Makefile.am. Otherwise the RPM can't be built from a source tarball.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in latest commit. I forgot to take out the commented lines, apologies..

- remove commented-out lines
- register the file for distribution in Makefile.am
@edolstra
Copy link
Member

Applied it, thanks!

@edolstra edolstra closed this May 31, 2012
edolstra added a commit that referenced this pull request Apr 25, 2017
fix nix-repl compilation after we don't have a global store variable anymore
meditans referenced this pull request in Ericson2314/nix Aug 28, 2020
zolodev pushed a commit to zolodev/nix that referenced this pull request Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants