repl: disable progress-bar explicitly, fix drawing regression#2249
Closed
dtzWill wants to merge 1 commit intoNixOS:masterfrom
Closed
repl: disable progress-bar explicitly, fix drawing regression#2249dtzWill wants to merge 1 commit intoNixOS:masterfrom
dtzWill wants to merge 1 commit intoNixOS:masterfrom
Conversation
Fixes 'nix repl' having prompt drawn-over after 44de71a. Apparently repl has ProgressBar enabled like other nix commands, so after that change after 1 sec an empty line (at least at first) would be drawn over the prompt, which is of course no good. AFAICT builds from repl didn't actually use the progress bar anyway since builds are done in a child via `nix-store -r`. Accordingly the easy fix is to disable progress bar for the repl, but we may want to revisit as progress bar would be nifty to have for builds done from repl :).
Member
Author
|
Beep boop, pinging because I feel bad for causing the breakage in an earlier PR. |
Member
Author
|
Okay it appears Not sure if there are other cases? I'll see about other solutions that preserve this behavior... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 'nix repl' having prompt drawn-over after
44de71a.
Apparently repl has ProgressBar enabled like other nix commands,
so after that change after 1 sec an empty line (at least at first)
would be drawn over the prompt, which is of course no good.
AFAICT builds from repl didn't actually use the progress bar anyway
since builds are done in a child via
nix-store -r.Accordingly the easy fix is to disable progress bar for the repl,
but we may want to revisit as progress bar would be nifty
to have for builds done from repl :).
Apologies for the breakage and for not noticing this sooner.