Revert "fix(libstore/filetransfer): enable TCP keep-alive on curl han… - #15522
Merged
Conversation
…dles" This reverts commit 736abd5. TCP keepalive with 60s idle/interval causes S3 to respond with RequestTimeout (HTTP 400) when curl reuses connections that S3 has already logically closed. S3 aggressively drops idle connections and sends 'Connection: close', but keepalive keeps the TCP socket alive, so curl thinks it can reuse a connection the server has already abandoned. This produced ~17.8k upload failures on Hydra after the change was deployed.
lovesegfault
approved these changes
Mar 19, 2026
Mic92
added
the
backport 2.34-maintenance
|
Successfully created backport PR for |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…dles"
This reverts commit 736abd5.
TCP keepalive with 60s idle/interval causes S3 to respond with RequestTimeout (HTTP 400) when curl reuses connections that S3 has already logically closed. S3 aggressively drops idle connections and sends 'Connection: close', but keepalive keeps the TCP socket alive, so curl thinks it can reuse a connection the server has already abandoned.
This produced ~17.8k upload failures on Hydra after the change was deployed.