Fix package-related CLI messages#15349
Merged
xokdvium merged 3 commits intoNixOS:masterfrom Feb 27, 2026
Merged
Conversation
github-actions
bot
added
the
with-tests
roberth
added
language
xokdvium
approved these changes
Feb 26, 2026
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
|
Yeah github is dying apparently... Will kick it once it lets me |
Contributor
|
Hm seems like a legitimate failure? https://github.com/NixOS/nix/actions/runs/22445776079/job/65005629517?pr=15349 |
Improve coverage ahead of changes to get-drvs.cc and related code. Each fixture is a separate file to avoid line-number churn in error expectations.
The error had nothing to do with content-addressed derivations; it triggers when a supposed derivation attrset simply lacks an outPath attribute.
forceStringNoCtx error messages leaked internal string context representation (e.g. '!out!<hash>-name.drv'). Use DerivedPath syntax instead: '<store-path>^out' for built, plain path for opaque, and '<drv-path> (deep)' for deep derivation references.
roberth
force-pushed
the
fix-cli-messages
branch
from
da28b00 to
eda9c01
Compare
Member
Author
|
I got the store dir wrong on vm tests. Fixed by following the established pattern. |
Member
Author
|
It's green 🎉 merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Make changes to diagnostics observable.
Leveling for eval caching. Can't build on broken code. Petty, I know ;)
Commits
.cmdstarts with exit code (sue me)hash^outinstead of internal!out!hashformatContext
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.