Return AutoCloseFD in open-like functions#15346
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Feb 26, 2026
Merged
Conversation
This reflects the fact that it is returning a new, "owned" file descriptor, that it is the caller's responsibility to close. Co-authored-by: Amaan Qureshi <git@amaanq.com>
Ericson2314
approved these changes
Feb 26, 2026
Member
|
I think this will help clear up what we should be doing for #15258 in particular |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This reflects the fact that it is returning a new, "owned" file descriptor, that it is the caller's responsibility to close.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.