Revert "libstore: replace unlink() with std::filesystem::remove()"#15344
Merged
Ericson2314 merged 1 commit intomasterfrom Feb 26, 2026
Merged
Revert "libstore: replace unlink() with std::filesystem::remove()"#15344Ericson2314 merged 1 commit intomasterfrom
Ericson2314 merged 1 commit intomasterfrom
Conversation
This reverts commit b8caabe. `std::filesystem::remove` will actually do a `rmdir` for directories. Per https://en.cppreference.com/w/cpp/filesystem/remove.html : > The file or empty directory identified by the path p is deleted as if > by the POSIX remove. Symlinks are not followed (symlink is removed, > not its target). See https://pubs.opengroup.org/onlinepubs/9699919799/functions/remove.html This is a behavior change that we can't be sure is fine, so let's revert for now. We can do an unlink wrapper later to avoid the `.string()`.
github-actions
bot
added
new-cli
xokdvium
approved these changes
Feb 26, 2026
xokdvium
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit b8caabe.
std::filesystem::removewill actually do armdirfor directories. Per https://en.cppreference.com/w/cpp/filesystem/remove.html :See
https://pubs.opengroup.org/onlinepubs/9699919799/functions/remove.html
This is a behavior change that we can't be sure is fine, so let's revert for now. We can do an unlink wrapper later to avoid the
.string().Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.