filetransfer: Use libcurl for Content-Encoding/Transfer-Encoding transparent decompression#15336
Merged
Ericson2314 merged 2 commits intomasterfrom Feb 26, 2026
Merged
filetransfer: Use libcurl for Content-Encoding/Transfer-Encoding transparent decompression#15336Ericson2314 merged 2 commits intomasterfrom
Ericson2314 merged 2 commits intomasterfrom
Conversation
Wastes slightly less memory. Also gets the doc-comments in order.
xokdvium
force-pushed
the
libcurl-content-encoding
branch
from
c328ef7 to
333f863
Compare
Ericson2314
approved these changes
Feb 25, 2026
xokdvium
force-pushed
the
libcurl-content-encoding
branch
2 times, most recently
from
361c82f to
0f8d999
Compare
xokdvium
commented
Feb 25, 2026
|
|
||
| pkg_hash = get_package_hash(PKGS['C']) | ||
|
|
||
| # Verify .narinfo has xz compression |
Contributor
Author
There was a problem hiding this comment.
I think using xz here was clearly a mistake, because no other http client can actually decompress such stuff...
edef1c
approved these changes
Feb 25, 2026
…sparent decompression Get rid of manual decompression entirely. We can support zstd, br, deflate (which was broken previously) and gzip/x-gzip encodings via curl without manual work on our side. This is the same approach that was taken by lix. Also adds some tests for x-gzip support.
xokdvium
force-pushed
the
libcurl-content-encoding
branch
from
0f8d999 to
fa07d9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Get rid of manual decompression entirely. We can support zstd, br,
deflate (which was broken previously) and gzip/x-gzip encodings via curl
without manual work on our side. This is the same approach that was taken by lix.
Also adds some tests for x-gzip support.
Context
Fixes #14324.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.