DerivationBuilderImpl: Add more hardening for writeBuilderFile#15328
Merged
Ericson2314 merged 1 commit intomasterfrom Feb 24, 2026
Merged
DerivationBuilderImpl: Add more hardening for writeBuilderFile#15328Ericson2314 merged 1 commit intomasterfrom
Ericson2314 merged 1 commit intomasterfrom
Conversation
xokdvium
commented
Feb 24, 2026
Adds additional layers of hardening for various file-writing utility functions in the derivation builder. Bad names in non-structured attrs case are already checked against `[A-Za-z_][A-Za-z0-9_.-]*` regex, so this isn't an issue, but adding more hardening is good regardless.
xokdvium
force-pushed
the
more-hardening-file-system-at-builders
branch
from
7032c3d to
246c3fe
Compare
xokdvium
commented
Feb 24, 2026
| auto path = std::filesystem::path(tmpDir) / name; | ||
| AutoCloseFD fd{ | ||
| openat(tmpDirFd.get(), name.c_str(), O_WRONLY | O_TRUNC | O_CREAT | O_CLOEXEC | O_EXCL | O_NOFOLLOW, 0666)}; | ||
| auto relPath = CanonPath(name); |
Contributor
Author
There was a problem hiding this comment.
It might be worth adding a CanonFilename type to verify this in the constructor or something I suppose.
Ericson2314
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Adds additional layers of hardening for various file-writing utility
functions in the derivation builder. Bad names in non-structured attrs
case are already checked against
[A-Za-z_][A-Za-z0-9_.-]*regex, sothis isn't an issue, but adding more hardening is good regardless.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.