libutil: Fix writeFull to respect allowInterrupts#15319
Merged
xokdvium merged 1 commit intoNixOS:masterfrom Feb 23, 2026
Merged
libutil: Fix writeFull to respect allowInterrupts#15319xokdvium merged 1 commit intoNixOS:masterfrom
xokdvium merged 1 commit intoNixOS:masterfrom
Conversation
c0e849b broke interrupt handling since writeFull started throwing Interrupted even when allowInterrupts was false. This would lead to exceptions leaking out when they must not (for example during progress bar shutdown).
xokdvium
force-pushed
the
fix-interrupts-write-full
branch
from
91589d7 to
658c775
Compare
Comment on lines
77
to
+88
| /** | ||
| * Platform-specific write from a buffer. | ||
| * | ||
| * Thin wrapper around ::write (Unix) or WriteFile (Windows). | ||
| * Handles EINTR on Unix. | ||
| * | ||
| * @param fd The file descriptor to write to | ||
| * @param buffer The buffer to write from | ||
| * @return The number of bytes actually written | ||
| * @throws SystemError on failure | ||
| */ | ||
| size_t write(Descriptor fd, std::span<const std::byte> buffer); | ||
| size_t write(Descriptor fd, std::span<const std::byte> buffer, bool allowInterrupts); |
Member
There was a problem hiding this comment.
missing docstring for the new param
lovesegfault
approved these changes
Feb 23, 2026
Member
lovesegfault
left a comment
lovesegfault
left a comment
There was a problem hiding this comment.
approved, but left a comment on a stale docstring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
c0e849b broke interrupt handling since
writeFullstarted throwingInterruptedeven whenallowInterruptswas false. This would lead to exceptions leaking out when they must not (for example during progress bar shutdown).Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.