fix(EvalState): Use make_shared for enable_shared_from_this compatibi…#15291
Merged
edolstra merged 1 commit intoNixOS:masterfrom Feb 18, 2026
Merged
Conversation
…lity EvalState inherits from enable_shared_from_this (added in b4c24a2 for debugRepl), but was being stack-allocated or created with make_unique in several places. This causes bad_weak_ptr errors when shared_from_this is called. Convert all EvalState allocations to use make_shared.
github-actions
bot
added
new-cli
edolstra
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…lity
EvalState inherits from enable_shared_from_this (added in b4c24a2 for debugRepl), but was being stack-allocated or created with make_unique in several places. This causes bad_weak_ptr errors when shared_from_this is called.
Convert all EvalState allocations to use make_shared.
Motivation
Might fix a crash.
Brings debugger support in the old CLI closer if anyone's interested.
Context
Was needed at some point in my eval cache work.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.