Merged
Conversation
This makes the current hard-coded 7-day `nix-cache-info` TTL configurable, making `--offline` and `--refresh` do the right thing.
github-actions
bot
added
new-cli
xokdvium
reviewed
Feb 18, 2026
Contributor
xokdvium
left a comment
xokdvium
left a comment
There was a problem hiding this comment.
Worth a release note? Otherwise LGTM
xokdvium
approved these changes
Feb 18, 2026
xokdvium
reviewed
Feb 26, 2026
| auto i = state.caches.find(uri); | ||
| if (i == state.caches.end()) { | ||
| auto queryCache(state.queryCache.use()(uri)(time(0) - cacheInfoTtl)); | ||
| auto queryCache(state.queryCache.use()(uri)(time(0) - settings.ttlMeta)); |
Contributor
There was a problem hiding this comment.
This is subtle, note that the test on i686 (and other 32 bit platforms) fails because this does a silent integral unsigned promotion.
https://hydra.nixos.org/build/322992746/nixlog/1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This makes the current hard-coded 7-day
nix-cache-infoTTL configurable, making--offlineand--refreshdo the right thing.Based on DeterminateSystems#355.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.