Get rid of SysError and WinError derived classes#15284
Draft
Ericson2314 wants to merge 1 commit intomasterfrom
Draft
Get rid of SysError and WinError derived classes#15284Ericson2314 wants to merge 1 commit intomasterfrom
SysError and WinError derived classes#15284Ericson2314 wants to merge 1 commit intomasterfrom
Conversation
All we need is `SystemError`, and the various ways to construct it can be done with static methods that are more informative. Catching the derived classes was a footgun that is now impossible, because one can only has `SystemError` to catch. I did however make `SysError` and `WinError` top-level function wrappers in order to avoid churn in the vast majority of call sites.
github-actions
bot
added
new-cli
|
🎉 All dependencies have been resolved ! |
Member
Author
|
Drafting because this is not a priority. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
All we need is
SystemError, and the various ways to construct it can be done with static methods that are more informative. Catching the derived classes was a footgun that is now impossible, because one can only hasSystemErrorto catch.I did however make
SysErrorandWinErrortop-level function wrappers in order to avoid churn in the vast majority of call sites.Context
Depends on #15283
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.