LocalStore: stop creating outdated profiles symlink#15277
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Feb 20, 2026
Merged
LocalStore: stop creating outdated profiles symlink#15277Ericson2314 merged 1 commit intoNixOS:masterfrom
Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
store
Member
|
This looks good. Two things that would be nice to happen:
|
The gcroots/profiles link became outdated in aeb810b when the GC code started reading directly from /profiles, and gcroots/profiles was even partially deleted in that commit.
puffnfresh
force-pushed
the
windows/remove-profiles-symlink
branch
from
22c6f62 to
9799023
Compare
Member
Author
|
Found the commit, referenced it and rebased/squashed. |
Ericson2314
approved these changes
Feb 20, 2026
Contributor
|
Perhaps this is fixing #13351 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GC already knows where profiles are via stateDir, so the profiles symlink in gcroots is unnecessary. Always create gcRootsDir unconditionally instead of gating on its existence.
Motivation
Symlinks pose some issues on Windows and I don't see a reason to get this one to work because it's outdated.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.