libutil: More robust check for NIX_UBSAN_ENABLED#15273
Merged
Ericson2314 merged 1 commit intomasterfrom Feb 18, 2026
Merged
Conversation
Member
|
I dunno if this is good? Because this makes it worse in the case where we do make undefined variables an error, because it means if we mess up the meson later and forgot to define the variable, we wouldn't notice in the header? |
Contributor
Author
|
There's still a check - that's why I've added it to error.cc. We do in fact make undefined macros an error and that will catch it. I just wanted to make sure that we don't impose this on out-of-tree users. |
In 3df91be I forgot that the header might get included out-of-tree with -Wundef. Let's make this a public config option for libutil as it can affect function bodies in headers.
xokdvium
force-pushed
the
more-robust-ubsan-macro
branch
from
fc06e83 to
db853cf
Compare
Ericson2314
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In 3df91be I forgot that the header
might get included out-of-tree with -Wundef. Let's make this a public
config option for libutil as it can affect function bodies in headers.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.