tests: quote PATH in external-builders test heredoc#15267
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Feb 17, 2026
Merged
tests: quote PATH in external-builders test heredoc#15267Ericson2314 merged 1 commit intoNixOS:masterfrom
PATH in external-builders test heredoc#15267Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
with-tests
Ericson2314
reviewed
Feb 17, 2026
The external-builders test expands `$PATH` into a heredoc without quotes, so any `PATH` entry containing spaces causes bash to parse the line as a command instead of an assignment, failing the test.
amaanq
force-pushed
the
fix-external-builders-path
branch
from
553a24f to
0b7629d
Compare
Ericson2314
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The external-builders test expands $PATH into a heredoc without quotes,
so any PATH entry containing spaces (e.g. "Application Support/carapace")
causes bash to parse the line as a command instead of an assignment. This
breaks the test on any macOS system with such entries.
Context
I was testing out #15244 on my Mac and noticed the
external-builderstest failing due to this. ThePATHenv variable on my Mac does have a space, thanks to theApplication Supportdirectory.Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.