libfetchers/git-utils: Add GitError class for deduplicating error…#15265
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Feb 17, 2026
Merged
libfetchers/git-utils: Add GitError class for deduplicating error…#15265Ericson2314 merged 1 commit intoNixOS:masterfrom
Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
fetching
roberth
approved these changes
Feb 16, 2026
Member
roberth
left a comment
roberth
left a comment
There was a problem hiding this comment.
I would suggest GitError but it doesn't matter for this private class.
…sage printing Consolidates all the error message formatting in one place. It was very weird and tiring to remember to call git_error_last() in all the places.
xokdvium
force-pushed
the
libgit2-error
branch
from
a6b2cd4 to
c1bfa30
Compare
xokdvium
changed the title
Contributor
Author
|
Changed to |
Ericson2314
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… message printing
Motivation
Consolidates all the error message formatting in one place. It was very weird and tiring to remember to call
git_error_last()in all the places.Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.