Split file-system-at.{cc,hh} from file-descriptor.{cc,hh}#15251
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Feb 16, 2026
Merged
Split file-system-at.{cc,hh} from file-descriptor.{cc,hh}#15251Ericson2314 merged 1 commit intoNixOS:masterfrom
file-system-at.{cc,hh} from file-descriptor.{cc,hh}#15251Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
Ericson2314
force-pushed
the
file-system-at
branch
from
7639569 to
478b606
Compare
`file-descriptor.{cc,hh}` was getting too big, split out
`file-system-at.{cc,hh}` for the FD-based file system stuff,
`file-descriptor.{cc,hh}` will only be for the fundamental primitives
that are file-system agnostic and work on almost all file types.
Review with `git show --color-moved` to see that this is indeed all
moving.
Ericson2314
force-pushed
the
file-system-at
branch
from
478b606 to
af7e585
Compare
xokdvium
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
file-descriptor.{cc,hh}was getting too big, split outfile-system-at.{cc,hh}for the FD-based file system stuff,file-descriptor.{cc,hh}will only be for the fundamental primitives that are file-system agnostic and work on almost all file types.Context
Review with
git show --color-movedto see that this is indeed all moving.Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.