libutil: fix isInDir rejecting paths starting with dot#15241
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Feb 15, 2026
Merged
libutil: fix isInDir rejecting paths starting with dot#15241Ericson2314 merged 1 commit intoNixOS:masterfrom
isInDir rejecting paths starting with dot#15241Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
amaanq
changed the title
amaanq
changed the title
amaanq
changed the title
isInDir rejecting paths starting with dot
Ericson2314
approved these changes
Feb 15, 2026
Member
Ericson2314
left a comment
Ericson2314
left a comment
There was a problem hiding this comment.
https://stackoverflow.com/questions/62503197/check-if-path-contains-another-in-c++ you should leave a comment there too!
Ericson2314
reviewed
Feb 15, 2026
The old check rejected any relative path whose first character was a dot, producing false negatives for valid descendants like `.ssh` or `.config`. This commit changes the logic such that now it inspects the first path component via `path::begin()`, only rejects `.` and `..` rather than anything dot-prefixed. Fixes NixOS#15207.
Ericson2314
approved these changes
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The old check rejected any relative path whose first character was a dot, producing false negatives for valid descendants like
.sshor.config. This commit changes the logic such that now it inspects the first path component viapath::begin(), only rejects.and..rather than anything dot-prefixed.Context
isInDirimplementation #15207Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.