libstore: remove Settings::nixStore in favor of StoreConfigBase::getDefaultNixStoreDir#15233
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Feb 13, 2026
Merged
Conversation
github-actions
bot
added
the
store
Ericson2314
reviewed
Feb 13, 2026
Ericson2314
reviewed
Feb 13, 2026
Ericson2314
reviewed
Feb 13, 2026
amaanq
force-pushed
the
remove-nixstore-global
branch
from
7ab7260 to
1cd7a28
Compare
…etDefaultNixStoreDir` This commit removes the `nixStore` member from `Settings` and instead computes the default Nix store directory directly in `StoreConfigBase::getDefaultNixStoreDir()` from env vars (`NIX_STORE_DIR`, `NIX_STORE`) or the compile-time default. The method is made public so callers that previously reached through the global `settings.nixStore` can use it instead. Progress on NixOS#5638
amaanq
force-pushed
the
remove-nixstore-global
branch
from
1cd7a28 to
12f9738
Compare
Ericson2314
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This commit removes the
nixStoremember fromSettingsand instead computes the default Nix store directory directly inStoreConfigBase::getDefaultNixStoreDir()from env vars (NIX_STORE_DIR,NIX_STORE) or the compile-time default. The method is made public so callers that previously reached through the globalsettings.nixStorecan use it instead.Context
Progress on #5638
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.