libstore: inline willBuildLocally and canBuildLocally into call sites#15232
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Feb 13, 2026
Merged
libstore: inline willBuildLocally and canBuildLocally into call sites#15232Ericson2314 merged 1 commit intoNixOS:masterfrom
willBuildLocally and canBuildLocally into call sites#15232Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
…ites This commit inlines `DerivationOptions::willBuildLocally` and `DerivationOptions::canBuildLocally` into their sole call site in `DerivationBuildingGoal::tryToBuild`. The `canBuildLocally` logic is now a lambda capturing the surrounding context, and `willBuildLocally` is replaced by `drvOptions.preferLocalBuild && canBuildLocally`. Progress on NixOS#5638 Co-authored-by: John Ericson <John.Ericson@Obsidian.Systems>
amaanq
force-pushed
the
inline-buildlocally
branch
from
70f4066 to
7106de1
Compare
Ericson2314
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This commit inlines
DerivationOptions::willBuildLocallyandDerivationOptions::canBuildLocallyinto their sole call site inDerivationBuildingGoal::tryToBuild. ThecanBuildLocallylogic is now a lambda capturing the surrounding context, andwillBuildLocallyis replaced bydrvOptions.preferLocalBuild && canBuildLocally. The corresponding method declarations, implementations, and test assertions are removed.Context
Progress on #5638
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.