Emit basic dry run message for garbage collection#15229
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Feb 13, 2026
Merged
Emit basic dry run message for garbage collection#15229Ericson2314 merged 1 commit intoNixOS:masterfrom
Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
lisanna-dettwyler
requested review from
Ericson2314 and
edolstra
as code owners
lisanna-dettwyler
force-pushed
the
fix-gc-dry-run
branch
from
67840a7 to
0b7d738
Compare
Member
|
@lisanna-dettwyler Could you make |
Ericson2314
reviewed
Feb 13, 2026
nix store gc: prints number of paths that would be freed, but not bytes nix-collect-garbage: ditto nix-store --gc: retains current behavior It would be very non-trivial to also compute the bytes that would be freed, due to hardlinking in the store. Also adds checking for incompatible mixing of dry-run and max-freed options. Resolves NixOS#5704 Signed-off-by: Lisanna Dettwyler <lisanna.dettwyler@gmail.com>
lisanna-dettwyler
force-pushed
the
fix-gc-dry-run
branch
from
0b7d738 to
fdfc772
Compare
Ericson2314
approved these changes
Feb 13, 2026
Member
Ericson2314
left a comment
Ericson2314
left a comment
There was a problem hiding this comment.
Looks great, thanks so much!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nix store gc: prints number of paths that would be freed, but not bytes
nix-collect-garbage: ditto
nix-store --gc: retains current behavior
It would be very non-trivial to also compute the bytes that would be freed, due to hardlinking in the store.
Also adds checking for incompatible mixing of dry-run and max-freed options.
Resolves #5704
Motivation
A very basic output (path count) is better than the current behavior (no output / no-op). The current behavior is kind of dangerous because a user may take the empty output of
--dry-runat face value, and assume running without it will not delete anything (or will delete less than it actually will, if combined with--delete-old).Context
#5704
#5705
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.