libstore: extract ProfileDirsOptions from Settings#15228
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Feb 13, 2026
Merged
libstore: extract ProfileDirsOptions from Settings#15228Ericson2314 merged 1 commit intoNixOS:masterfrom
ProfileDirsOptions from Settings#15228Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
This commit moves `nixStateDir` and `useXDGBaseDirectories` into a dedicated `ProfileDirsOptions` struct and threads it through the profile directory functions (`profilesDir`, `rootProfilesDir`, `defaultChannelsDir`, `rootChannelsDir`, `getDefaultProfile`) so they no longer read from the global `Settings` object directly. This follows the same pattern as `LocalSettings`, `WorkerSettings`, and `NarInfoDiskCacheSettings`. Progress on NixOS#5638 Co-authored-by: Amaan Qureshi <git@amaanq.com>
amaanq
force-pushed
the
profile-dirs-options
branch
from
d4cf0ce to
002cbef
Compare
Ericson2314
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This commit moves
nixStateDiranduseXDGBaseDirectoriesinto a dedicatedProfileDirsOptionsstruct and threads it through the profile directory functions (profilesDir,rootProfilesDir,defaultChannelsDir,rootChannelsDir,getDefaultProfile) so they no longer read from the globalSettingsobject directly. This follows the same pattern asLocalSettings,WorkerSettings, andNarInfoDiskCacheSettings.Context
Progress on #5638
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.