libstore: extract NarInfoDiskCacheSettings from Settings#15227
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Feb 13, 2026
Merged
libstore: extract NarInfoDiskCacheSettings from Settings#15227Ericson2314 merged 1 commit intoNixOS:masterfrom
NarInfoDiskCacheSettings from Settings#15227Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
new-cli
Ericson2314
reviewed
Feb 13, 2026
amaanq
force-pushed
the
narinfo-disk-cache-settings
branch
4 times, most recently
from
af7c384 to
badd6d0
Compare
This commit moves `ttlNegativeNarInfoCache` and `ttlPositiveNarInfoCache` into a dedicated `NarInfoDiskCacheSettings` struct that `Settings` privately inherits from, following the same pattern as `LocalSettings`, `LogFileSettings`, and `WorkerSettings`. `NarInfoDiskCache` now takes explicit `NarInfoDiskCacheSettings` and `SQLiteSettings` in its constructor instead of reading from the global. The singleton `getNarInfoDiskCache()` is replaced with a `NarInfoDiskCache::get()` static method that accepts these settings, though they are only used on the first call (subsequent calls return the cached instance regardless of arguments). Progress on NixOS#5638
amaanq
force-pushed
the
narinfo-disk-cache-settings
branch
from
badd6d0 to
dc636dd
Compare
Ericson2314
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This commit moves
ttlNegativeNarInfoCacheandttlPositiveNarInfoCacheinto a dedicatedNarInfoDiskCacheSettingsstruct thatSettingsprivately inherits from, following the same pattern asLocalSettings,LogFileSettings, andWorkerSettings.NarInfoDiskCachenow takes explicitNarInfoDiskCacheSettingsandSQLiteSettingsin its constructor instead of reading from the global. The singletongetNarInfoDiskCache()is replaced with aNarInfoDiskCache::get()static method that accepts these settings, though they are only used on the first call (subsequent calls return the cached instance regardless of arguments).Context
Progress on #5638
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.