libstore: pass stateDir to acquireUserLock instead of using global#15217
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Feb 13, 2026
Merged
libstore: pass stateDir to acquireUserLock instead of using global#15217Ericson2314 merged 1 commit intoNixOS:masterfrom
stateDir to acquireUserLock instead of using global#15217Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
amaanq
force-pushed
the
acquire-user-lock-state-dir
branch
from
e63164b to
dd6672a
Compare
amaanq
changed the title
amaanq
changed the title
stateDir to acquireUserLock instead of using global
amaanq
force-pushed
the
acquire-user-lock-state-dir
branch
2 times, most recently
from
031cc6e to
8aeb096
Compare
Ericson2314
approved these changes
Feb 13, 2026
Member
|
In particular, we might switch this to using the per-local-store state dir rather than global one at some point. |
This makes `acquireUserLock` take an explicit stateDir parameter, since it was previously reaching into the global settings object just to read `nixStateDir` for constructing the userpool paths. Progress on NixOS#5638
auto-merge was automatically disabled
February 13, 2026 00:43
Head branch was pushed to by a user without write access
amaanq
force-pushed
the
acquire-user-lock-state-dir
branch
from
8aeb096 to
cecbe9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This makes
acquireUserLocktake an explicit stateDir parameter,since it was previously reaching into the global settings object
just to read
nixStateDirfor constructing the userpool paths.Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.