Merged
Conversation
xokdvium
reviewed
Feb 12, 2026
Idle connections in libcurl's connection pool can be silently dropped by the OS or intermediate firewalls/NATs before they can be reused, forcing new TCP connections to be created. This is especially problematic for HTTP/1.1 endpoints where multiplexing is unavailable. Enable TCP keep-alive with a 60-second idle/interval on all curl easy handles to prevent idle connection drops and improve connection reuse.
lovesegfault
force-pushed
the
fix-s3-conn-reuse
branch
from
5e80ac7 to
252dd9e
Compare
lovesegfault
added
the
backport 2.33-maintenance
lovesegfault
force-pushed
the
fix-s3-conn-reuse
branch
from
252dd9e to
7950d1a
Compare
lovesegfault
force-pushed
the
fix-s3-conn-reuse
branch
2 times, most recently
from
32ee842 to
a261fef
Compare
lovesegfault
force-pushed
the
fix-s3-conn-reuse
branch
3 times, most recently
from
667ac54 to
a0aa580
Compare
lovesegfault
force-pushed
the
fix-s3-conn-reuse
branch
from
a0aa580 to
8412b68
Compare
…tyle option S3 binary caches now use virtual-hosted-style URLs by default for standard AWS endpoints. Path-style endpoints (s3.region.amazonaws.com) only serve HTTP/1.1, preventing HTTP/2 multiplexing and causing TCP TIME_WAIT socket exhaustion under high concurrency. Virtual-hosted-style endpoints (bucket.s3.region.amazonaws.com) support HTTP/2, enabling multiplexing with the existing CURLPIPE_MULTIPLEX configuration. Add a new `addressing-style` store option (auto/path/virtual) to control this behavior. `auto` (default) uses virtual-hosted-style for standard AWS endpoints and path-style for custom endpoints. `path` forces path-style for backwards compatibility. `virtual` forces virtual-hosted- style for all endpoints including custom ones. Fixes: #15208
lovesegfault
force-pushed
the
fix-s3-conn-reuse
branch
from
8412b68 to
759f6c8
Compare
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Context
Fixes: #15208
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.