libstore: extract WorkerSettings from Settings#15211
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Feb 12, 2026
Merged
libstore: extract WorkerSettings from Settings#15211Ericson2314 merged 1 commit intoNixOS:masterfrom
WorkerSettings from Settings#15211Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
amaanq
force-pushed
the
worker-settings
branch
3 times, most recently
from
7d216bf to
0bdeb75
Compare
github-actions
bot
added
new-cli
amaanq
force-pushed
the
worker-settings
branch
2 times, most recently
from
47e39b9 to
1766585
Compare
github-actions
bot
added
fetching
amaanq
force-pushed
the
worker-settings
branch
from
1766585 to
1fd6ce5
Compare
Ericson2314
approved these changes
Feb 12, 2026
This commit moves `pollInterval`, `maxSubstitutionJobs`, `postBuildHook`, and `logLines` into a dedicated `WorkerSettings` struct that `Settings` privately inherits from, as they are only used by the build worker subsystem. This follows the same pattern as `LocalSettings` and `LogFileSettings`.
auto-merge was automatically disabled
February 12, 2026 20:31
Head branch was pushed to by a user without write access
amaanq
force-pushed
the
worker-settings
branch
from
1fd6ce5 to
d3388d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This commit moves
pollInterval,maxSubstitutionJobs,postBuildHook, andlogLinesinto a dedicatedWorkerSettingsstruct thatSettingsprivately inherits from, as they are only used by the build worker subsystem. This follows the same pattern asLocalSettingsandLogFileSettings.Progress on #5638
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.