libstore: add `HttpBinaryCacheStoreConfig` constructor that takes a ` ParsedURL` by amaanq · Pull Request #15209 · NixOS/nix

amaanq · 2026-02-12T01:10:25Z

Motivation

In the https-store tests, a TestHttpBinaryCacheStoreConfig is constructed with a call to format to create the cache uri. This commit adds a constructor to HttpBinaryCacheStoreConfig to remove the need for this call, and updates the test type to leverage this so we're no longer manually calling fmt on a string to format the port.

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

src/libstore-tests/http-binary-cache-store.cc

src/libstore/http-binary-cache-store.cc

src/libstore/legacy-ssh-store.cc

Ericson2314

Approving, but holding off merging because @xokdvium asked me too on an earlier version of this.

src/libstore/http-binary-cache-store.cc

…ParsedURL` In the https-store tests, a `TestHttpBinaryCacheStoreConfig` is constructed with a call to format to create the cache uri. This commit adds a constructor to `HttpBinaryCacheStoreConfig` to remove the need for this call, and updates the test type to leverage this so we're no longer manually calling fmt on a string to format the port.

src/libstore-test-support/include/nix/store/tests/https-store.hh

amaanq requested review from Ericson2314 and edolstra as code owners February 12, 2026 01:10

github-actions bot added the store Issues and pull requests concerning the Nix store label Feb 12, 2026

amaanq force-pushed the http-store-port-ctor branch from ed14eaa to 97fc235 Compare February 12, 2026 14:46

amaanq changed the title ~~libstore: add HttpBinaryCacheStoreConfig constructor that takes the host and port separately~~ libstore: add host and port constructors to store configs Feb 12, 2026

amaanq force-pushed the http-store-port-ctor branch from 97fc235 to 648d835 Compare February 12, 2026 15:04