Increase the open file soft limit to the hard limit#15205
Merged
Conversation
On some platforms (macOS), the default soft limit is very low, but the hard limit is high. So let's just raise it the maximum permitted.
Member
Author
|
This may be a Determinate Nix specific issue because it's keeping the tarball cache open in Regardless, it probably doesn't hurt to bump the open file limit since there have been various bug reports about this in the past (#8684, #10158). (Though this PR only helps if the hard limit is higher than the soft limit.) |
xokdvium
approved these changes
Feb 11, 2026
Contributor
xokdvium
left a comment
xokdvium
left a comment
There was a problem hiding this comment.
Good enough for now, but the libgit2 issue should probably get addressed at the root cause. It doesn't seem to close any file descriptors for .pack or .idx files from me strace-ing things.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
On some platforms (macOS), the default soft limit is very low, but the hard limit is high. So let's just raise it the maximum permitted.
macOS users reported that the tarball cache was failing with errors like
It's possible this started happening because of the multithreaded tarball cache import opening more files in parallel. Hopefully this fixes it.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.