libstore: migrate caFile, netrcFile, and downloadSpeed to FileTransferSettings#15202
Merged
Ericson2314 merged 2 commits intoNixOS:masterfrom Feb 11, 2026
Conversation
github-actions
bot
added
the
fetching
amaanq
force-pushed
the
migrate-ca-netrc-downloadspeed-filetransfer
branch
3 times, most recently
from
1bdbf1d to
fc4d962
Compare
`hashedMirrors` is only relevant to local builds (it is consumed by `builtin:fetchurl` during derivation building) but lived in the global `Settings` class. This moves it to `LocalSettings` where it belongs and threads it through `BuiltinBuilderContext` so `fetchurl.cc` reads it from the context instead of reaching into `settings` directly.
…TransferSettings` The `caFile`, `netrcFile`, and `downloadSpeed` settings are only used by the file transfer subsystem but lived in the global `Settings` class. This moves them to `FileTransferSettings` where they belong. Co-authored-by: Amaan Qureshi <git@amaanq.com>
amaanq
force-pushed
the
migrate-ca-netrc-downloadspeed-filetransfer
branch
from
fc4d962 to
04d13a9
Compare
Ericson2314
approved these changes
Feb 11, 2026
Member
Ericson2314
left a comment
Ericson2314
left a comment
There was a problem hiding this comment.
Good, simplifying the unit test with a fresh FileTransferSettings will be done in a separate commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In the first commit,
hashedMirrorsis only relevant to local builds (it is consumed bybuiltin:fetchurlduring derivation building) but lived in the globalSettingsclass. This moves it toLocalSettingswhere it belongsand threads it through
BuiltinBuilderContextsofetchurl.ccreadsit from the context instead of reaching into
settingsdirectly.In the second commit, the
caFile,netrcFile, anddownloadSpeedsettings are only used bythe file transfer subsystem but lived in the global
Settingsclass.This moves them to
FileTransferSettingswhere they belong, and extractsa
BootstrapSettingsstruct for early-init paths (nixConfDir,nixUserConfFiles) that need to be available beforeSettingsisconstructed.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.