Skip to content

libutil: Assorted collection of fixes, address UBSan failure in AutoDelete #15172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xokdvium merged 2 commits into from
Feb 8, 2026
Merged

libutil: Assorted collection of fixes, address UBSan failure in AutoDelete #15172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b90755
libutil: Fix uninitialised variable in AutoDelete
xokdvium Feb 7, 2026
3cd840d
libutil: Fix error message in readLinkAt
xokdvium Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/libutil/file-system.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,14 +469,15 @@ void createDirs(const std::filesystem::path & path)

AutoDelete::AutoDelete()
: del{false}
, recursive(false)
{
}

AutoDelete::AutoDelete(const std::filesystem::path & p, bool recursive)
: _path(p)
, del(true)
, recursive(recursive)
{
del = true;
this->recursive = recursive;
}

void AutoDelete::deletePath()
Expand Down
2 changes: 1 addition & 1 deletion src/libutil/unix/file-descriptor.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ OsString readLinkAt(Descriptor dirFd, const CanonPath & path)
buf.resize(bufSize);
ssize_t rlSize = ::readlinkat(dirFd, path.rel_c_str(), buf.data(), bufSize);
if (rlSize == -1)
throw SysError("reading symbolic link '%1%'", path);
throw SysError("reading symbolic link '%1%' relative to parent directory", path.rel());
else if (rlSize < bufSize)
return {buf.data(), static_cast<std::size_t>(rlSize)};
}
Expand Down
Loading