Add Derivation::shouldResolve() method, use in nix-shell#15170
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Feb 7, 2026
Merged
Add Derivation::shouldResolve() method, use in nix-shell#15170Ericson2314 merged 1 commit intoNixOS:masterfrom
Derivation::shouldResolve() method, use in nix-shell#15170Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
Extract the logic for determining whether a derivation should be resolved before building into a dedicated method. Then use that to not resolve unnecessarily in `nix-shell`.
Ericson2314
approved these changes
Feb 6, 2026
xokdvium
reviewed
Feb 6, 2026
Comment on lines
-534
to
535
| if (experimentalFeatureSettings.isEnabled(Xp::CaDerivations)) { | ||
| if (drv.shouldResolve()) { | ||
| auto resolvedDrv = drv.tryResolve(*store); |
Contributor
There was a problem hiding this comment.
Shouldn't this still require the XP feature? Or would that check be redundant and we'd fail earlier anyway?
Member
There was a problem hiding this comment.
It would be redundant, yeah. Though I wouldn't mind putting more redundant checks in the body of the function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Extract the logic for determining whether a derivation should be resolved
before building into a dedicated method. Then use that to not resolve
unnecessarily in
nix-shell.Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.