libcmd/repl: Fix issues with :ll before anything is loaded, get rid o…#15167
Merged
libcmd/repl: Fix issues with :ll before anything is loaded, get rid o…#15167
Conversation
github-actions
bot
added
new-cli
xokdvium
force-pushed
the
repl-last-loaded-fix
branch
from
2cf34f7 to
a8b7437
Compare
…f store parameters to constructors Fixes abort on :ll if nothing has been loaded yet. Also gets rid of redundant openStore() calls that were dead code (store can be extracted from EvalState already) and arguably openStore is a layer violation. Also catches EPIPE in case the pager gets interrupted to avoid superfluous error messages.
xokdvium
force-pushed
the
repl-last-loaded-fix
branch
from
a8b7437 to
bcc6390
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…f store parameters to constructors
Motivation
Fixes abort on :ll if nothing has been loaded yet. Also gets rid of redundant openStore() calls that were dead code (store can be extracted from EvalState already) and arguably openStore is a layer violation.
Also catches EPIPE in case the pager gets interrupted to avoid superfluous error messages.
Context
Fixes #15128.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.