tests: Add Nix 1.11.16 compatibility test#15164
Open
roberth wants to merge 1 commit intoNixOS:masterfrom
Open
Conversation
github-actions
bot
added
the
with-tests
Contributor
Hm, didn't compat with pre 2.0 protocols get yeeted a while back? |
Member
Author
|
Apparently not, and if anything, this shows that it's quite easy to extend the range of tested versions. |
Helps catch protocol compatibility issues with very old daemons.
roberth
force-pushed
the
test-compat-nix-1.16
branch
from
f7c9ba7 to
7dd43d0
Compare
Member
|
Huh wow, I'm surprised this worked so easily! |
Member
It is pretty surprising that this works, since we dropped support for protocol versions < 18 (137a551) and 1.11.* is on version 15. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Helps catch protocol compatibility issues with very old daemons.
I've used this to verify something about the worker protocol.
It's not perfect but works and catches a possible mistake; see #15168.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.