lang: Turn URL literals into a hard error#15151
Conversation
github-actions
bot
added
documentation
new-cli
Mic92
force-pushed
the
deprecated-url-literals
branch
from
6c6a3b8 to
f6250b3
Compare
Co-authored-by: piegames <git@piegames.de> Co-authored-by: eldritch horrors <pennae@lix.systems>
This removes the experimental feature 'no-url-literals' which disabled URL literals. URL literals are now disabled by default. However, a new deprecated feature 'url-literals' is added to re-enable them for transitional purposes. Unquoted URLs are deprecated and will be removed in a future release.
Mic92
force-pushed
the
deprecated-url-literals
branch
from
f6250b3 to
1cee2e7
Compare
| /** | ||
| * Just because writing `DeprecatedFeature::UrlLiterals` is way too long | ||
| */ | ||
| using Dep = DeprecatedFeature; |
There was a problem hiding this comment.
Seems too generic IMO. Dep could get mistaken for "dependency"
There was a problem hiding this comment.
Might be better to discuss this in #15150
instead, which adds deprecated features, unless you want to not have this as an intermediate PR.
| * Semi-magic conversion to and from json. | ||
| * See the nlohmann/json readme for more details. |
There was a problem hiding this comment.
What does this mean? Can we also stick with JSON_IMPL for this?
There was a problem hiding this comment.
Will have to read up on the original commit from Lix, why it has been done this way. I can have a look at JSON_IMPL.
|
To be honest, I've never seen the point in removing URL literals. All this will do is break people's Nix expressions for no good reason.
They should never be removed entirely because it breaks the ability of Nix to build old Nix expressions. |
So we have viable 3 options here:
I think I am leaning towards warnings as well because injecting feature flags can be quiet annoying when nix is used somewhere inside another tool. |
|
Yeah, a generic warning infrastructure sounds good. |
|
Indeed it was idea-approved |
|
Closed in favor of #15326 |
5 participants
This removes the experimental feature 'no-url-literals' which disabled URL literals.
URL literals are now disabled by default.
However, a new deprecated feature 'url-literals' is added to re-enable them for transitional purposes.
Unquoted URLs are deprecated and will be removed in a future release.
Depends on #15150