libutil: Add openNewFileForWrite helper function, wrap callsites#15141
Merged
Ericson2314 merged 1 commit intomasterfrom Feb 4, 2026
Merged
libutil: Add openNewFileForWrite helper function, wrap callsites#15141Ericson2314 merged 1 commit intomasterfrom
Ericson2314 merged 1 commit intomasterfrom
Conversation
This is purely a fix to use CreateFileW in mingw builds. Also adds some FIXMEs for suspicious symlink following on truncation that can probably be tightened down without any problems (other than nix-channel), but for now this is a no-op change other than consistently using O_CLOEXEC, which is harmless.
xokdvium
commented
Feb 3, 2026
| AutoCloseFD fd = toDescriptor(open(profileFile.string().c_str(), O_WRONLY | O_CREAT | O_TRUNC, 0660)); | ||
| AutoCloseFD fd = openNewFileForWrite( | ||
| profileFile, | ||
| 0660, |
Contributor
Author
There was a problem hiding this comment.
Not sure why I did it this way. Generally we override the umask to 0022 everywhere
xokdvium
commented
Feb 3, 2026
| 0666, | ||
| { | ||
| .truncateExisting = true, | ||
| .followSymlinksOnTruncate = true, /* FIXME: Probably shouldn't follow symlinks. */ |
Contributor
Author
There was a problem hiding this comment.
Pretty sure we never expect this to be able to become a symlink, unless the user is doing something very naughty
Ericson2314
approved these changes
Feb 3, 2026
Ericson2314
approved these changes
Feb 3, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This is purely a fix to use
CreateFileWin mingw builds. Also adds some FIXMEs for suspicious symlink following on truncation that can probably be tightened down without any problems (other than nix-channel), but for now this is a no-op change other than consistently usingO_CLOEXEC, which is harmless.Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.