Refactor fstat into a wrapper in libutil#15111
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Jan 28, 2026
Merged
Conversation
We use a different fstat on posix and windows systems, and not all fstat users were using the correct one. Factor out fstat to make the change easier. See also a13de50 for other stat functions
xokdvium
approved these changes
Jan 28, 2026
| PosixStat st; | ||
| if (fstat(fromDescriptorReadOnly(fd.get()), &st) == -1) | ||
| throw SysError("statting file"); | ||
| auto st = nix::fstat(fromDescriptorReadOnly(fd.get())); |
Contributor
There was a problem hiding this comment.
FWIW, fromDescriptorReadOnly performs a destructive move out of HANDLE on windows and that HANDLE must not be used anymore or closed with CloseHandle. Instead it must use a the ::close from the C runtime, so this is kind of borked. A pre-existing issue, but still something to keep in mind :(
Member
There was a problem hiding this comment.
Yes longer term we'll want to use https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-getfileinformationbyhandle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We use a different fstat on posix and windows systems, and not all fstat users were using the correct one. Factor out fstat to make the change easier.
Context
See also a13de50 for other stat functions
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.