libstore: move command-specific settings to their own files#15099
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Jan 27, 2026
Merged
Conversation
The two settings `envKeepDerivations` and `upgradeNixStorePathUrl` were only used in one command each, so it makes more sense to move them to their own files. This commit moves them both into a small self-contained settings struct and registers them with the global config.
Ericson2314
approved these changes
Jan 27, 2026
Member
Ericson2314
left a comment
Ericson2314
left a comment
There was a problem hiding this comment.
This is exactly analogous to what I did way back in #7739, and it should be good for the same reason.
(We should care much more about global variables in the libraries than in the end executable.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The two settings
envKeepDerivationsandupgradeNixStorePathUrlwere only used in one command each, so it makes more sense to move them to their own files. This commit moves them both into a small self-contained settings struct and registers them with the global config.Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.