Fix build-hook setting being clobbered#15083
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Jan 26, 2026
Merged
Conversation
settings.buildHook.setDefault was running after nix.conf was parsed, causing whatever value settings.buildHook had to be clobbered. Re-arrange the logic so that the default is set before nix.conf is parsed, so that custom build hooks can be used by specifying them in nix.conf. Signed-off-by: Lisanna Dettwyler <lisanna.dettwyler@gmail.com>
xokdvium
approved these changes
Jan 26, 2026
Contributor
xokdvium
left a comment
xokdvium
left a comment
There was a problem hiding this comment.
Hm this makes sense to me. I think the order of calls shouldn't matter too much in the sense that this setting doesn't depend on an initialised library.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
settings.buildHook.setDefault was running after nix.conf was parsed, causing whatever value settings.buildHook had to be clobbered. Re-arrange the logic so that the default is set before nix.conf is parsed, so that custom build hooks can be used by specifying them in nix.conf.
Context
Currently it is only possible to override the build hook by passing
--optionon the command line.Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.