Share the exception-using chmod wrapper with more code#15075
Merged
Ericson2314 merged 1 commit intomasterfrom Jan 24, 2026
Merged
Share the exception-using chmod wrapper with more code#15075Ericson2314 merged 1 commit intomasterfrom
chmod wrapper with more code#15075Ericson2314 merged 1 commit intomasterfrom
Conversation
github-actions
bot
added
the
store
Ericson2314
force-pushed
the
chmod-wrapper
branch
3 times, most recently
from
0682a10 to
4ca9066
Compare
It is not just useful to `DerivationBuilder`.
Ericson2314
force-pushed
the
chmod-wrapper
branch
from
4ca9066 to
6e2e53a
Compare
Ericson2314
commented
Jan 24, 2026
| chmod(topTmpDir.c_str(), 0755); | ||
| chmod(tmpDir.c_str(), 0755); | ||
| chmod(topTmpDir, 0755); | ||
| chmod(tmpDir, 0755); |
Member
Author
There was a problem hiding this comment.
This wasn't error checking before, but it was not justified why this was the case. Assuming this was an oversight.
xokdvium
approved these changes
Jan 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.